[CI] Check that a second build has nothing to do - #23056
Merged
Merged
Conversation
guitargeek
force-pushed
the
ci-null-build-check
branch
from
August 10, 2026 07:46
6287e1a to
3691cf4
Compare
Test Results 23 files 23 suites 3d 22h 6m 44s ⏱️ For more details on these failures, see this check. Results for commit 90d53b9. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
ci-null-build-check
branch
3 times, most recently
from
August 11, 2026 07:55
b2b7f9d to
11a4407
Compare
guitargeek
force-pushed
the
ci-null-build-check
branch
2 times, most recently
from
August 12, 2026 15:08
859d948 to
e09da1f
Compare
guitargeek
marked this pull request as ready for review
August 12, 2026 16:37
pcanal
reviewed
Aug 12, 2026
pcanal
reviewed
Aug 12, 2026
pcanal
approved these changes
Aug 12, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
LGTM. (If I recall correctly, we tested earlier that the test did catch some failures, we should add in the PR summary links to those tests).
ROOT_STANDARD_LIBRARY_PACKAGE(... NO_SOURCES) provided the dummy source file that add_library() needs as the output of a custom command that touches it. All the packages of one directory share that output, and listing one custom command output in several independent targets that build in parallel is not supported; core/clingutils alone has 15 of them. Ninja and Make happen to get away with it, but with MSBuild the touch runs again on every build, so 14 of the 15 STL dictionaries were recompiled and relinked every time, along with everything depending on them. Write the file at configure time instead. Nothing touches it at build time anymore, so it cannot go stale under the targets that compile it. 🤖 Done with the help of AI
MSBuild re-executes these post-build events even when the build has nothing to do, and `cmake -E copy` rewrites its destination unconditionally, so every null build modified those files. Ninja and Makefiles are immune because there POST_BUILD steps only run when the target itself relinks. Use `cmake -E copy_if_different` so a no-op event leaves the destination untouched, and replace the data.h POST_BUILD hack with configure_file(... COPYONLY), the convention the sibling test directories already use for such runtime inputs. 🤖 Done with the help of AI
Building an already built tree twice in a row must be a no-op, apart from etc/gitinfo.txt which the gitinfotxt target rewrites on every build by design. When that is not the case, every incremental build pays for the targets that are needlessly redone plus everything depending on them. Add a null build check that runs on all platforms right after the build: it fingerprints every file in the build tree, builds again, and reports what was written. Doing it this way rather than parsing build tool output keeps it working across Ninja, Makefiles and MSBuild alike. The verdict is only acted on at the very end, after ctest, so that a spurious rebuild does not cost us the test results. 🤖 Done with the help of AI
guitargeek
force-pushed
the
ci-null-build-check
branch
from
August 13, 2026 06:37
e09da1f to
90d53b9
Compare
Contributor
Author
Thanks for the review! I added references in the PR description to the failures that the new check caught. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building an already built tree twice in a row must be a no-op, apart from etc/gitinfo.txt which the gitinfotxt target rewrites on every build by design. When that is not the case, every incremental build pays for the targets that are needlessly redone plus everything depending on them.
Add a null build check that runs on all platforms right after the build: it fingerprints every file in the build tree, builds again, and reports what was written. Doing it this way rather than parsing build tool output keeps it working across Ninja, Makefiles and MSBuild alike.
The verdict is only acted on at the very end, after ctest, so that a spurious rebuild does not cost us the test results.
🤖 Done with the help of AI
This new test caught problems in Windows (which were fixed in the two first commits of this PR), as well as the AlmaLinux 8 + Ninja issue that caused #21346 to get reverted.